React 18 #2807
Merged
React 18 #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzotki
commented
Jul 18, 2024
There was a problem hiding this comment.
This has to be adjusted before proper release:
https://github.com/brainly/style-guide/blob/ce89f5797654776b19fb16d6133f3af1038fb337/src/components/dialog/Dialog.tsx#L53C8-L53C20
Because of:
next-dev.js:20 Warning: Dialog: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.
at Dialog (webpack-internal:///../../../node_modules/brainly-style-guide/esm/components/dialog/Dialog.js:246:20)
kopach
reviewed
Jul 26, 2024
kopach
reviewed
Jul 26, 2024
kopach
reviewed
Jul 31, 2024
kopach
approved these changes
Jul 31, 2024
radekwarisch
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to react 18 and fix tests