Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pypa/gh-action-pypi-publish stable release v1 #456

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

lochhh
Copy link
Contributor

@lochhh lochhh commented Jan 30, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
In PR #449 a specific version tag was used. We could use the release/v1 branch instead, as it will receive updates and bug fixes automatically and there's no need to update the tag as frequently.

References

#449

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@lochhh lochhh marked this pull request as ready for review January 30, 2025 11:25
@IgorTatarnikov IgorTatarnikov self-requested a review January 30, 2025 13:31
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to me, @lochhh do you think it's worth changing across all repos?

@lochhh
Copy link
Contributor Author

lochhh commented Jan 30, 2025

This sounds good to me, @lochhh do you think it's worth changing across all repos?

Yup just wanted to start from the same first repo as the original PR.

@IgorTatarnikov IgorTatarnikov merged commit d32ab0b into brainglobe:main Jan 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants