-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document kim dev atlases in readme #444
Conversation
I've put this back into draft status due to #441 (comment) |
hey I'm just trying to figure out how to update the README to include this update. The issue i'm having is up until now I could just list the API name of each atlas (ie: kim_dev_mouse_P04_LSFM_20um), but with this update there are now too many combinations to list all. instead of kim_dev_mouse_P04_LSFM_20um should I say kim_dev_mouse_{age}_{modality}_{resolution}um? thanks! |
Just know that given a combination of (age, modality) there's only one resolution possible. Moreover, LSFM is always at 20um and, between between postnatals, it's always 50um. Perhaps make the resolution semantically different, to signify that the user has no voice in deciding the resolution? |
Sorry for the confusion @carlocastoldi and @PolarBean. There is a PR open to fix this #446, and I have regenerated the atlases with that script, so they have lowercase names now, as detailed in the PR too. I will upload to the GIN data repo tomorrow (need to focus on other things today), and update the GIN readme and the docs PR brainglobe/brainglobe.github.io#271 accordingly :) please bear with me! |
This is ready to be re-reviewed now @adamltyson (in respect to questions and suggestions above) I've put the atlases into the Readme separated by developmental timepoint, to be super-explicit about the names :) this is consistent with how it was for v0.0.1 which we had at P56 only. |
Thats a good solution for this atlas but for DeMBA (which has more than 50 ages) it may become a bit crowded. |
No description provided.