added nadkarni_mri_mouselemur #411
Conversation
There was a problem hiding this comment.
Thanks, @PolarBean
Largely looks good to me - made some comments to increase the code quality (I hope!)
I've run the validation on the atlas locally, and it looks like there's some spurious pixels in the annotation here (see left of canvas in screenshot below):
Not sure whether we should ask the original authors to fix this, or fix it ourselves programmatically. Thoughts welcome!
brainglobe_atlasapi/atlas_generation/atlas_scripts/nadkarni_mri_mouselemur.py
Outdated
Show resolved
Hide resolved
brainglobe_atlasapi/atlas_generation/atlas_scripts/nadkarni_mri_mouselemur.py
Outdated
Show resolved
Hide resolved
brainglobe_atlasapi/atlas_generation/atlas_scripts/nadkarni_mri_mouselemur.py
Show resolved
Hide resolved
brainglobe_atlasapi/atlas_generation/atlas_scripts/nadkarni_mri_mouselemur.py
Show resolved
Hide resolved
brainglobe_atlasapi/atlas_generation/atlas_scripts/nadkarni_mri_mouselemur.py
Outdated
Show resolved
Hide resolved
|
This should be ready for rereview |
related to other discussiongs I think we merge for the moment and make a brainglobe version later on with these pixels removed. |
There was a problem hiding this comment.
Looks good to me.
Tiny bug in the orientation, I think - I've suggested a change.
If you confirm you agree with this change @PolarBean I can upload to GIN.
brainglobe_atlasapi/atlas_generation/atlas_scripts/nadkarni_mri_mouselemur.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Alessandro Felder <[email protected]>
|
Awesome - thanks again @PolarBean |
Here this addresses this issue. Adding a mouse lemur atlas into brainglobe.
#410
This will be ready once I double check the orientation.