Support Ganglion v3 detection on MacOS native BLE #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed. 👍 |
retiutut
reviewed
Sep 22, 2023
| @@ -444,7 +454,6 @@ void GanglionNative::adapter_1_on_scan_found ( | |||
|
|
|||
| if (found) | |||
| { | |||
| firmware = strncmp (peripheral_identified, "Ganglion 1.3", 12) == 0 ? 3 : 2; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firmware version detection for Ganglion depends on parsing the advertised name of the device. On MacOS, the device name is always discovered as "Simblee" rather than the name intended to be advertised by the firmware. Since the device name is not determined correctly, the correct Ganglion firmware cannot be determined on MacOS.
This PR solves the above problem by reading the BLE Software Revision String characteristic. This characteristic explicitly provides the correct device firmware version.