Freeeeg128 #662
Freeeeg128 #662
Conversation
Add new board id to BoardIds enum: "Freeeeg128_Board = 52"
Add new board id to BoardIds enum: "FREEEEG128_BOARD = 52"
Include the: #include "freeeeg128.h" and also add new condition to switch
Add new jason board: "brainflow_boards_json [52], Freeeeg128"
Add the folder for Freeeeg128 to add #.h & #.cpp
file deleted
update #.cpp
update #.h
not sure about following
static constexpr int start_byte = 0xA0;
static constexpr int end_byte = 0xC0;
static constexpr double ads_gain = 8.0;
static constexpr double ads_vref = 2.5;
Update the "BOARD_CONTROLLER_SRC" to include freeeeg128
update the docs file Note: need to add the pic of device and add the website link
fixed the boards_json
fixed the FREEEEG128_BOARD
| void FreeEEG128::read_thread () | ||
| { | ||
| int res; | ||
| constexpr int max_size = 200; // random value bigger than package size which is unknown |
There was a problem hiding this comment.
@TedAhmadi did you test it?
I dont fully understand how it can work, since here max size is 200 and you set min_package_size to 1 + 128*3 which is bigger
There was a problem hiding this comment.
actually there should be a segfault or no data in buffer
Signed-off-by: Andrey Parfenov <[email protected]>
|
I pushed some changes to avoid copypaste between freeeg32 and 128, please pull and test them. I suppose there was a bug and more likely it didnt work before and I cannot test it |
|
also you need to validate sampling rate, record data for 10 seconds, store in a file and confirm that there are around |
|
no updates, and still not sure if it works or not. That should not damage the operation of freeeg32, so I will merge it, but will not update website with info about freeeg128 support and will not promote it anywhere |
I fixed the issue we have with a compile error, can you please compile it again?