-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeeeg128 #661
Closed
Closed
Freeeeg128 #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new board id to BoardIds enum: "Freeeeg128_Board = 52"
Add new board id to BoardIds enum: "FREEEEG128_BOARD = 52"
Include the: #include "freeeeg128.h" and also add new condition to switch
Add new jason board: "brainflow_boards_json [52], Freeeeg128"
Add the folder for Freeeeg128 to add #.h & #.cpp
file deleted
update #.cpp
update #.h not sure about following static constexpr int start_byte = 0xA0; static constexpr int end_byte = 0xC0; static constexpr double ads_gain = 8.0; static constexpr double ads_vref = 2.5;
Update the "BOARD_CONTROLLER_SRC" to include freeeeg128
update the docs file Note: need to add the pic of device and add the website link
fixed the boards_json
thanks @TedAhmadi ! It fails to compile, you can check build logs by clicking on the failed jobs |
fixed the FREEEEG128_BOARD
Yes I will fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I followed the instruction you sent me to add the freeeeg128 to the brain flow, I hope I had done all of the steps correctly. Please let me know if I need to do any future modifications.