-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: import explicit files #869
Draft
nikku
wants to merge
2
commits into
develop
Choose a base branch
from
esm
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
barmac,
a team and
marstamm
and removed request for
a team
March 12, 2024 09:59
Some tests are failing. I'm investigating why. |
bpmn-io-tasks
bot
added
in progress
Currently worked on
and removed
needs review
Review pending
labels
Mar 12, 2024
nikku
force-pushed
the
esm
branch
2 times, most recently
from
March 12, 2024 16:28
4915617
to
a92a7bc
Compare
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Mar 12, 2024
All fixed! |
Validated by #870 that this also works with strict (ESM) import checking. |
Draft
bpmn-io-tasks
bot
added
in progress
Currently worked on
and removed
needs review
Review pending
labels
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares us to migrate diagram-js to an ES module.
Related to #863