Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send/receive task unused global #145

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Sep 5, 2024

Closes #139

Proposed Changes

  • Messages referenced by Send/Receive Task won't throw warning unused global

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 5, 2024
* traverse only once for 🚀
* support message flows referencing messages
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works. I've done some refactoring on top to make sure we only traverse once and also cover message flows.

@philippfromme philippfromme merged commit 51735e7 into main Sep 10, 2024
8 of 10 checks passed
@philippfromme philippfromme deleted the 139-unused-message-ref branch September 10, 2024 11:06
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive "unused global" warning message on Receive Task and Send Task
2 participants