fix: no no-implicit-end error on compensation activity #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
requested changes
Sep 3, 2024
rules/no-implicit-end.js
Outdated
| @@ -32,6 +44,14 @@ module.exports = function() { | |||
| return false; | |||
| } | |||
|
|
|||
| if (is(node, 'bpmn:BoundaryEvent') && isCompensationEventDefinition(node)) { | |||
There was a problem hiding this comment.
We still want to treat this as an implicit end like any other boundary event.
For comparison, timer boundary event with the implicit end error.
bpmn-io-tasks
bot
added
in progress
abdul99ahad
force-pushed
the
140-compensation-activity
branch
from
99c621a
to
306ec92
Compare
abdul99ahad
force-pushed
the
140-compensation-activity
branch
from
306ec92
to
3e5b910
Compare
bpmn-io-tasks
bot
added
needs review
philippfromme
requested changes
Sep 3, 2024
rules/no-implicit-end.js
Outdated
| @@ -48,3 +82,21 @@ module.exports = function() { | |||
|
|
|||
| return { check }; | |||
| }; | |||
|
|
|||
| function findParent(node, type) { | |||
There was a problem hiding this comment.
Let's add this function to the utils and import it.
bpmn-io-tasks
bot
added
in progress
abdul99ahad
force-pushed
the
140-compensation-activity
branch
from
3e5b910
to
adf34b7
Compare
bpmn-io-tasks
bot
added
needs review
philippfromme
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140
Proposed Changes
no-implicit-errorChecklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}