BF+TST: Handle None values in dicom datasets

bpinsard · Jun 5, 2024 · 27856f1 · 27856f1
1 parent 615a914
commit 27856f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/dcmstack/extract.py b/src/dcmstack/extract.py
@@ -416,7 +416,7 @@ def _get_elem_value(self, elem):
                 value = elem.value
 
         #Handle any conversions
-        if elem.VR in self.conversions:
+        if elem.VR in self.conversions and value is not None:
             if n_vals == 1:
                 value = self.conversions[elem.VR](value)
             else:

diff --git a/test/test_extract.py b/test/test_extract.py
@@ -117,3 +117,9 @@ def test_non_reloc_private(self):
         meta_dict = extractor(self.data)
         assert meta_dict["CsaImage.EchoLinePosition"] == 64
         assert meta_dict['CsaSeries.MrPhoenixProtocol.sEFISPEC.bEFIDataValid'] == 1
+
+    def test_none_vals(self):
+        extractor = extract.MetaExtractor()
+        self.data.PercentSampling = None
+        meta_data = extractor(self.data)
+        assert "PercentSampling" not in meta_data