Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop support old Node version #548

Open
wants to merge 2 commits into
base: major-version
Choose a base branch
from

Conversation

congminh1254
Copy link
Member

No description provided.

@congminh1254 congminh1254 changed the base branch from support-ai-apis to main October 21, 2024 16:55
@congminh1254 congminh1254 changed the base branch from main to support-ai-apis October 22, 2024 14:34
@arjankowski
Copy link
Contributor

The commit should be marked as a breaking change because of dropping support for node.
So we have to add the !:
feat!: Drop support old Node version

"scripts": {
"test": "nyc mocha \"test/**/*.test.js\"",
"posttest": "npm run lint",
"lint": "eslint --fix ./src ./test",
"prepack": "oclif-dev manifest && oclif-dev readme --multi && npm shrinkwrap && git checkout origin/main -- package-lock.json",
"postpack": "rm -f oclif.manifest.json && rm -f npm-shrinkwrap.json",
"version": "oclif-dev readme --multi && git add README.md && git add docs",
"build": "oclif-dev pack:macos && rm -rf tmp/ && oclif-dev pack:win && rm -rf tmp/ && npm run binaries",
"binaries": "pkg --targets node12-macos-x64,node12-win-x64,node12-linux-x64 --out-path ./dist .",
"build": "oclif-dev pack:macos && rm -rf tmp/ && oclif-dev pack:win && rm -rf tmp/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the whole process of releasing on jenkins?

README.md Outdated Show resolved Hide resolved
@congminh1254
Copy link
Member Author

The commit should be marked as a breaking change because of dropping support for node. So we have to add the !: feat!: Drop support old Node version

This is a PR to the feature branch major-version, so I think the ! should be added when the feature branch merge to main later.

@arjankowski arjankowski changed the title feat: Drop support old Node version feat!: Drop support old Node version Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants