refactor: Move PHP settings checker into a class (#1188)

src/Console/Command/Compile.php

@@ -38,6 +38,7 @@
 use KevinGH\Box\Console\Logger\CompilerLogger;
 use KevinGH\Box\Console\MessageRenderer;
 use KevinGH\Box\Console\OpenFileDescriptorLimiter;
+use KevinGH\Box\Console\PhpSettingsChecker;
 use KevinGH\Box\Constants;
 use KevinGH\Box\MapFile;
 use KevinGH\Box\Phar\CompressionAlgorithm;
@@ -63,7 +64,6 @@
 use function implode;
 use function is_callable;
 use function is_string;
-use function KevinGH\Box\check_php_settings;
 use function KevinGH\Box\disable_parallel_processing;
 use function KevinGH\Box\format_size;
 use function KevinGH\Box\format_time;
@@ -190,7 +190,7 @@ public function execute(IO $io): int
             $io->setVerbosity(OutputInterface::VERBOSITY_DEBUG);
         }
 
-        check_php_settings($io);
+        PhpSettingsChecker::check($io);
 
         if ($io->getTypedOption(self::NO_PARALLEL_PROCESSING_OPTION)->asBoolean()) {
             disable_parallel_processing();

src/Console/Command/Extract.php

@@ -19,6 +19,7 @@
 use Fidry\Console\ExitCode;
 use Fidry\Console\IO;
 use Fidry\FileSystem\FS;
+use KevinGH\Box\Console\PhpSettingsChecker;
 use KevinGH\Box\Phar\InvalidPhar;
 use KevinGH\Box\Phar\PharFactory;
 use KevinGH\Box\Phar\PharMeta;
@@ -28,7 +29,6 @@
 use Throwable;
 use function bin2hex;
 use function file_exists;
-use function KevinGH\Box\check_php_settings;
 use function realpath;
 use function sprintf;
 use const DIRECTORY_SEPARATOR;
@@ -76,7 +76,7 @@ public function getConfiguration(): Configuration
 
     public function execute(IO $io): int
     {
-        check_php_settings($io);
+        PhpSettingsChecker::check($io);
 
         $pharPath = self::getPharFilePath($io);
         $outputDir = $io->getTypedArgument(self::OUTPUT_ARG)->asNonEmptyString();

src/Console/Command/Process.php

@@ -25,6 +25,7 @@
 use KevinGH\Box\Compactor\PhpScoper;
 use KevinGH\Box\Compactor\Placeholder;
 use KevinGH\Box\Configuration\Configuration;
+use KevinGH\Box\Console\PhpSettingsChecker;
 use stdClass;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
@@ -38,7 +39,6 @@
 use function explode;
 use function getcwd;
 use function implode;
-use function KevinGH\Box\check_php_settings;
 use function putenv;
 use function sprintf;
 use const KevinGH\Box\BOX_ALLOW_XDEBUG;
@@ -89,7 +89,7 @@ public function execute(IO $io): int
             putenv(BOX_ALLOW_XDEBUG.'=1');
         }
 
-        check_php_settings($io);
+        PhpSettingsChecker::check($io);
 
         ChangeWorkingDirOption::changeWorkingDirectory($io);
 

src/Console/PhpSettingsChecker.php

@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the box project.
+ *
+ * (c) Kevin Herrera <[email protected]>
+ *     Théo Fidry <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace KevinGH\Box\Console;
+
+use Fidry\Console\IO;
+use KevinGH\Box\Console\Php\PhpSettingsHandler;
+use KevinGH\Box\NotInstantiable;
+use Symfony\Component\Console\Logger\ConsoleLogger;
+
+/**
+ * @internal
+ */
+final class PhpSettingsChecker
+{
+    use NotInstantiable;
+
+    public static function check(IO $io): void
+    {
+        (new PhpSettingsHandler(
+            new ConsoleLogger(
+                $io->getOutput(),
+            ),
+        ))->check();
+    }
+}

src/functions.php

@@ -16,11 +16,8 @@
 
 use Composer\InstalledVersions;
 use ErrorException;
-use Fidry\Console\IO;
-use KevinGH\Box\Console\Php\PhpSettingsHandler;
 use Phar;
 use Symfony\Component\Console\Helper\Helper;
-use Symfony\Component\Console\Logger\ConsoleLogger;
 use Webmozart\Assert\Assert;
 use function bin2hex;
 use function class_alias;
@@ -199,18 +196,6 @@ function unique_id(string $prefix): string
     return $prefix.bin2hex(random_bytes(6));
 }
 
-/**
- * @private
- */
-function check_php_settings(IO $io): void
-{
-    (new PhpSettingsHandler(
-        new ConsoleLogger(
-            $io->getOutput(),
-        ),
-    ))->check();
-}
-
 /**
  * Converts errors to exceptions.
  *