added "data-sort-value" to ignored HTML attributes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks. Looking at it now, I wonder if it should/could be made more generic for all kinds of |
bovender
reviewed
Mar 31, 2020
| @@ -139,7 +139,7 @@ private function buildSplitter() { | |||
| '<div.*?>|<\/div>|' . // attributes of div elements | |||
| '<span.*?>|<\/span>|' . // attributes of span elements | |||
| '<file>[^<]*<\/file>|' . // stuff inside file elements | |||
| 'style=".+?"|class=".+?"|' . // styles and classes (e.g. of wikitables) | |||
| 'style=".+?"|class=".+?"|data-sort-value=".+?"|' . // styles and classes (e.g. of wikitables) | |||
There was a problem hiding this comment.
More generic variant could be:
Suggested change
| 'style=".+?"|class=".+?"|data-sort-value=".+?"|' . // styles and classes (e.g. of wikitables) | |
| 'style=".+?"|class=".+?"|data-[^=]+=".+?"|' . // styles and classes (e.g. of wikitables) |
?
There was a problem hiding this comment.
Hi, I don't have much time to test it, but what about something like this:
<[^>]*>
It would match all HTML Tags with or wihtout attributes.
Is there any case in which you have to replace anything inside a HTML tag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #46