Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge erroneous if statements in release workflow #375

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Sep 16, 2024

Description of changes:
Our release action is failing: https://github.com/bottlerocket-os/twoliter/actions/runs/10892134510

This is due to my change in #373, which added a duplicate if key to one of the release workflow
s yaml blocks.

Testing done:
I loaded the actions workflow with a yaml parser, and noted that it now succeeds:

release['jobs']['upload-artifacts']['if']
"${{ needs.create-release.outputs.has-releases == 'true'\n    && github.repository == 'bottlerocket-os/twoliter'\n}}\n"

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt
Copy link
Contributor Author

cbgbt commented Sep 16, 2024

Ah, @sumukhballal pointed out the GitHub actions integration in vscode and I noticed another error. I'll fix it in this PR.

@cbgbt cbgbt marked this pull request as draft September 16, 2024 21:29
@cbgbt cbgbt marked this pull request as ready for review September 16, 2024 21:31
@cbgbt cbgbt merged commit 15251cb into bottlerocket-os:develop Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants