Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue in EndpointExceptionError by changing the format of the error message. #3296

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ubaskota
Copy link
Contributor

@ubaskota ubaskota commented Nov 5, 2024

The current base class for EndpointResolutionError takes variable-length arguments; kwarg, and passing a positional argument to it returns a TypeError. This fix solves it by passing an argument in a proper format.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @ubaskota! It's probably worth adding a quick note to the description to the effect of:

This PR addresses a miss in the initial implementation of error handling in our EndpointProvider. The missing kwarg for passing the exception message results in an error being raised while trying to raise our EndpointResolutionError.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (b1279af) to head (d89d6e9).
Report is 59 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3296   +/-   ##
========================================
  Coverage    93.18%   93.18%           
========================================
  Files           66       66           
  Lines        14345    14375   +30     
========================================
+ Hits         13367    13396   +29     
- Misses         978      979    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ubaskota ubaskota changed the title Fixes the issue in EndpointExceptionError by changing the format of the error message Fixes the issue in EndpointExceptionError by changing the format of the error message. The current base class for EndpointResolutionError takes variable-length arguments; kwarg, and passing a positional argument to it returns a TypeError. This fix solves it by passing an argument in a proper format. Nov 5, 2024
@ubaskota ubaskota changed the title Fixes the issue in EndpointExceptionError by changing the format of the error message. The current base class for EndpointResolutionError takes variable-length arguments; kwarg, and passing a positional argument to it returns a TypeError. This fix solves it by passing an argument in a proper format. Fixes the issue in EndpointExceptionError by changing the format of the error message. Nov 5, 2024
@jonathan343 jonathan343 merged commit 179e8b5 into boto:develop Nov 5, 2024
40 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Nov 6, 2024
* release-1.35.55:
  Bumping version to 1.35.55
  Update to latest models
  Fixes the issue in EndpointExceptionError by changing the format of the error message (#3296)
  Query compatibility mode header (#3295)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants