Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query compatibility mode header #3295

Merged
merged 3 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "enhancement",
"category": "Query Compatibility Mode Header",
alexgromero marked this conversation as resolved.
Show resolved Hide resolved
"description": "Adds logic for custom header to support services migrating away from the AWS Query protocol."
alexgromero marked this conversation as resolved.
Show resolved Hide resolved
}
7 changes: 7 additions & 0 deletions botocore/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,12 @@ def _update_status_code(response, **kwargs):
http_response.status_code = parsed_status_code


def add_query_compatibility_header(model, params, **kwargs):
if not model.service_model.is_query_compatible:
return
params['headers']['x-amzn-query-mode'] = 'true'


# This is a list of (event_name, handler).
# When a Session is created, everything in this list will be
# automatically registered with that Session.
Expand Down Expand Up @@ -1348,6 +1354,7 @@ def _update_status_code(response, **kwargs):
('docs.response-params.s3.*.complete-section', document_expires_shape),
('before-endpoint-resolution.s3', customize_endpoint_resolver_builtins),
('before-call', add_recursion_detection_header),
('before-call', add_query_compatibility_header),
('before-call.s3', add_expect_header),
('before-call.glacier', add_glacier_version),
('before-call.apigateway', add_accept_header),
Expand Down
4 changes: 4 additions & 0 deletions botocore/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,10 @@ def signature_version(self):
def signature_version(self, value):
self._signature_version = value

@CachedProperty
def is_query_compatible(self):
return 'awsQueryCompatible' in self.metadata

def __repr__(self):
return f'{self.__class__.__name__}({self.service_name})'

Expand Down
8 changes: 8 additions & 0 deletions tests/functional/test_sqs.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,11 @@ def test_query_compatible_error_parsing(self):
self.client.delete_queue(
QueueUrl="not-a-real-queue-botocore",
)

def test_query_compatibility_mode_header_sent(self):
with self.http_stubber as stub:
stub.add_response()
self.client.delete_queue(QueueUrl="not-a-real-queue-botocore")
request = self.http_stubber.requests[0]
assert 'x-amzn-query-mode' in request.headers
assert request.headers['x-amzn-query-mode'] == b'true'
17 changes: 17 additions & 0 deletions tests/unit/test_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1944,3 +1944,20 @@ def test_document_response_params_without_expires(document_expires_mocks):
mocks['section'].get_section.assert_not_called()
mocks['param_section'].add_new_section.assert_not_called()
mocks['doc_section'].write.assert_not_called()


def test_add_query_compatibility_header():
service_model = ServiceModel({'metadata': {'awsQueryCompatible': {}}})
operation_model = OperationModel(mock.Mock(), service_model)
request_dict = {'headers': {}}
handlers.add_query_compatibility_header(operation_model, request_dict)
assert 'x-amzn-query-mode' in request_dict['headers']
assert request_dict['headers']['x-amzn-query-mode'] == 'true'


def test_does_not_add_query_compatibility_header():
service_model = ServiceModel({'metadata': {}})
operation_model = OperationModel(mock.Mock(), service_model)
request_dict = {'headers': {}}
handlers.add_query_compatibility_header(operation_model, request_dict)
assert 'x-amzn-query-mode' not in request_dict['headers']
Loading