Add support for CRC64NVME when the CRT is available. #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## flexible-checksums-v2 #3273 +/- ##
========================================================
Coverage ? 93.16%
========================================================
Files ? 66
Lines ? 14363
Branches ? 0
========================================================
Hits ? 13381
Misses ? 982
Partials ? 0 ☔ View full report in Codecov by Sentry. |
jonathan343
force-pushed
the
add-crc64nvme
branch
from
e40a9f5
to
4d9f87c
Compare
jonathan343
force-pushed
the
add-crc64nvme
branch
from
4d9f87c
to
dba2f1b
Compare
nateprewitt
approved these changes
Oct 8, 2024
jonathan343
added a commit
that referenced
this pull request
Oct 22, 2024
* Add support for CRC64NVME when the CRT is available. * Update crc64nvme priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for the CRC64NVME checksum algorithm made available in
awscrt-0.22.0. Similar to the existing CRC32C checskum algorithm, CRC64NVME will only be available when users have installed the optional CRT dependency. If CRT isn't installed and users try to this algorithm, aMissingDependencyExceptionwill be thrown.Important
Tests are currently expected to fail until #3274 is merged.#3274 is merged and tests are passing.