Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove worklink client following the service deprecation #3264

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove worklink client following the service deprecation #3264

merged 1 commit into from
Sep 25, 2024

Conversation

alexgromero
Copy link
Contributor

This PR removes the Amazon WorkLink client from Boto3 following the service deprecation.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (e0f04ab) to head (906aa42).
Report is 111 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3264      +/-   ##
===========================================
+ Coverage    93.15%   93.17%   +0.02%     
===========================================
  Files           66       66              
  Lines        14287    14339      +52     
===========================================
+ Hits         13309    13361      +52     
  Misses         978      978

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jonathan343
jonathan343 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jonathan343 jonathan343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alexgromero alexgromero merged commit 3126dc8 into boto:develop Sep 25, 2024
34 checks passed
@alexgromero alexgromero deleted the worklink-deprecation branch September 25, 2024 15:54
aws-sdk-python-automation added a commit that referenced this pull request Sep 25, 2024
@aws-sdk-python-automation
Merge branch 'release-1.35.27'
e7d437a 
* release-1.35.27:
  Bumping version to 1.35.27
  Update endpoints model
  Update to latest models
  remove worklink client following the service deprecation (#3264)
  remove dead comment (#3265)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Sep 26, 2024
@alexgromero @hswong3i
remove worklink client following the service deprecation (boto#3264)
52498ec
alexgromero added a commit to alexgromero/botocore that referenced this pull request Oct 8, 2024
@alexgromero
remove worklink client following the service deprecation (boto#3264)
240394f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan343 jonathan343 jonathan343 approved these changes

@SamRemis SamRemis Awaiting requested review from SamRemis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgromero @codecov-commenter @jonathan343