feat(query): Add custom lancedb query generation for lancedb search #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonv
requested changes
Jan 1, 2025
swiftide/tests/lancedb.rs
Outdated
| .context("Failed to create vector similarity query")? | ||
| .column(&vector_field); | ||
|
|
||
| let result_limit = usize::try_from(similarity_config.top_k()) |
There was a problem hiding this comment.
Maybe just use an arbitrary number? Feels a bit complicated to just create a new search strategy, if you really need a number.
shamb0
force-pushed
the
feat/lancedb/custom-strategy-integration
branch
2 times, most recently
from
1705ed1 to
6e99c2d
Compare
|
Hi @timonv, I've updated the custom strategy implementation in Would appreciate your thoughts on whether this prototype aligns with your expectations. |
This commit implements the CustomStrategy trait for LanceDB vector similarity search, enabling flexible query generation with metadata filtering. Signed-off-by: shamb0 <[email protected]>
shamb0
force-pushed
the
feat/lancedb/custom-strategy-integration
branch
from
6e99c2d to
39d7b97
Compare
timonv
previously approved these changes
Jan 12, 2025
Merged
timonv
pushed a commit
that referenced
this pull request
Jan 16, 2025
## 🤖 New release * `swiftide`: 0.16.4 -> 0.17.0 (✓ API compatible changes) * `swiftide-agents`: 0.16.4 -> 0.17.0 (✓ API compatible changes) * `swiftide-core`: 0.16.4 -> 0.17.0 (⚠️ API breaking changes) * `swiftide-macros`: 0.16.4 -> 0.17.0 * `swiftide-indexing`: 0.16.4 -> 0.17.0 * `swiftide-integrations`: 0.16.4 -> 0.17.0 (✓ API compatible changes) * `swiftide-query`: 0.16.4 -> 0.17.0 ###⚠️ `swiftide-core` breaking changes ``` --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/trait_method_added.ron Failed in: trait method swiftide_core::agent_traits::AgentContext::redrive in file /tmp/.tmps520nh/swiftide/swiftide-core/src/agent_traits.rs:153 trait method swiftide_core::AgentContext::redrive in file /tmp/.tmps520nh/swiftide/swiftide-core/src/agent_traits.rs:153 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `swiftide` <blockquote> ## [0.17.0](v0.16.4...v0.17.0) - 2025-01-16 ### New features - [835c35e](835c35e) *(agents)* Redrive completions manually on failure (#551) ````text Sometimes LLMs fail a completion without deterministic errors, or the user case where you just want to retry. `redrive` can now be called on a context, popping any new messages (if any), and making the messages available again to the agent. ```` - [f83f3f0](f83f3f0) *(agents)* Implement ToolExecutor for common dyn pointers (#549) - [7f85735](7f85735) *(query)* Add custom lancedb query generation for lancedb search (#518) - [ce4e34b](ce4e34b) *(tree-sitter)* Add golang support (#552) ````text Seems someone conveniently forgot to add Golang support for the splitter. ```` ### Miscellaneous - [0000000](0000000) Update Cargo.lock dependencies **Full Changelog**: 0.16.4...0.17.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #511
This PR implements the
CustomStrategy<Q>trait for LanceDB, enabling flexible and customizable vector similarity search capabilities. The implementation follows the successful pattern established in the pgvector integration while leveraging LanceDB-specific features.