Platform specific #ifs
#1966
Merged
Platform specific #ifs
#1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
reviewed
Jan 8, 2025
| double discrete_sum = | ||
| std::accumulate(discrete_samples.begin(), discrete_samples.end(), | ||
| decltype(discrete_samples)::value_type(0)); | ||
| #if __APPLE__ |
There was a problem hiding this comment.
I don’t see differences between these different paths??
There was a problem hiding this comment.
I am using the CI to understand the differences in the results since I can avoid instrumenting individual platform runs manually. I'll request a review when this is ready.
|
Based on our discussion, I found out that libstdc++ has an open bug that causes this difference in PRNG results. https://stackoverflow.com/a/45767223/1236990 |
dellaert
approved these changes
Jan 9, 2025
| EXPECT(assert_equal(Vector2(20.0070499, 39.9942591), actual[X(1)], 1e-5)); | ||
| EXPECT(assert_equal(Vector2(109.976501, 229.990945), actual[X(0)], 1e-5)); | ||
| #elif _WIN32 | ||
| EXPECT(assert_equal(Vector2(20.0129382, 40.0039798), actual[X(1)], 1e-5)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
ifs for different platforms so that we can get regression tests running.I was recently bitten by a bug that wasn't checked because these tests were commented out.