Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows CI, add Python wrapper for EliminateQR #1757

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix Windows CI, add Python wrapper for EliminateQR #1757

merged 4 commits into from
May 30, 2024

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented May 29, 2024 •
edited
Loading

Need to get Windows CI fixed, blocking other PRs from merging

@ProfFan ProfFan changed the title Fan/add eliminate qr Fix Windows CI, add Python wrapper for EliminateQR May 29, 2024
@ProfFan ProfFan requested review from varunagrawal and dellaert May 29, 2024 23:56
varunagrawal
varunagrawal reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though would be great to have a test showing the wrapping working.

@varunagrawal varunagrawal merged commit 50021ed into develop May 30, 2024
31 checks passed
@varunagrawal varunagrawal deleted the fan/add_eliminate_qr branch May 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProfFan @varunagrawal