Tiny Updates to Python Wrapper #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems our Windows CI is broken, we need to fix that first before merging this PR |
|
Hi @contagon could you merge master so the CI could run? |
|
Just merged develop, let me know if that didn't do the trick. |
dellaert
approved these changes
Jun 10, 2024
|
@ProfFan any idea as to why that Python CI keeps breaking? It also does not pass on my PR from yesterday. |
|
@dellaert I think it's GH Actions using the ephemeral cloud runners that got killed. You just need to manually restart the tasks that were stuck... |
|
@ProfFan I am currently having issues with the Python CI failing on a segfault on Windows. Could something in this PR inadvertently be causing the issue? |
|
Nevermind, I reverted the develop branch changes in my PR and the issue is still there. Seems like this might be a Windows+Python issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using gtsam, I just ran into a handful of functions that hadn't been added to the python wrapper. They're all fairly straightforward and worked out of the box as you'd expect. I figured others may have use for them too.
Let me know if there's any questions/issues with any of them though.