Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile gtsam python for windows
I manage to create a ci worker that compile gtsam python for windows.
There is an error when the OUTPUT_NAME of python target is the same name of the linkage lib on windows only.
https://github.com/talregev/gtsam/actions/runs/7093971320/job/19308372633#step:13:1092
It still fail because I change the OUTPUT_NAME . I am not sure how to solve it, but I solve the other compilation errors.
@dellaert Can you take a look on it?