Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reprojection with fisheye camera model #1678

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add reprojection with fisheye camera model #1678

merged 2 commits into from
Nov 30, 2023
+3 −1

Conversation

kkelchte
Copy link
Contributor

Add the ProjectionFactorPPPCal3Fisheye factor reprojection for the fisheye camera in python interface.

@varunagrawal
Copy link
Collaborator

@kkelchte can you please add a unit test in the python/gtsam/tests directory to verify that the wrapping is indeed successful? It can be very simple, similar to a Cal3_S2 example.

dellaert
dellaert approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !!!!

@dellaert
Copy link
Member

I think this is just adding a type to the wrapper, does not need unit test.

@dellaert dellaert merged commit 6f89bd8 into borglab:develop Nov 30, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkelchte @varunagrawal @dellaert