Update style.css

[DrDBanner]

Wrong Template referenced. Child theme would not appear in Themes browser. This change fixes that.

Update: I installed all of the packages via composer and the child template did not appear in the theme browser. The browser stated 'The parent theme is missing. Please install the "bootscore-main" parent theme.' . After changing this value it did appear. The Metatdata theme name in the "bootscore/style.css" file is "bootscore" not "bootscore-main" hence I assume it fails.

[crftwrk]

Thank you for this PR, but that is not correct because all of our themes and plugins have -main suffix included in releases https://github.com/bootscore/bootscore/releases/latest/download/bootscore-main.zip.

We included suffix a couple of years ago for several reasons, in retrospect this wasn't a good idea but we are not able to change this now because it will have huge impact on existing installations. See pinned issue as well #33

We had this discussion already several times in the past, so I set this PR to draft and moved to v6 where we are allowed to do breaking changes. We can discuss then one more time if we remove/keep -main.

[DrDBanner]

Hey, ... perhaps you just focus on something different. The point isn't the package name but the "theme name" in the style.css ... This seems to be the point of reference, not how the folder is named. And if I install via composer there is just no suffix in the package folder name. It is named plain bootscore. Perhaps the fix is to either rename the composer repo or change the installation code in the documentation in order to create a suffixed main template folder. Something along the lines of that.

[crftwrk]

All good, we are talking about the same thing. In your second screenshots, theme folders have name bootscore and bootscore-child. Both folders are wrong, you have to rename them into bootscore-main and bootscore-child-main, because as mentioned above -main suffix is part of all our themes and plugins and Template: bootscore-main is correct.

Please click https://github.com/bootscore/bootscore/releases/latest/download/bootscore-main.zip and unzip file, you will see.

It seems that Composer skips the -main in your installation, but that's wrong. Please rename your folders.

[DrDBanner]

Ah. Ok. Then the documentation needs some love on that end, at least that prevents confusion. I just use composer for grabbing and updating. Same would become true if I just cloned the repo.

[crftwrk]

Same would become true if I just cloned the repo.

No, if you clone the repo -main suffix is there as well. That's why we included it. But as I mentioned, we can discuss this in v6.

[DrDBanner]

I am confused. Cloned. No suffix. Obviously. Perhaps we just talk left and right. 🤷‍♀️

[crftwrk]

Sorry, misunderstood. I did not mean clone, I mean pressing the Code > Download zip button.

[DrDBanner]

Well, we can't force users to do that, but those using cli tend to use the documentation. So, a hint there should create more clarity.

[crftwrk]

So, a hint there should create more clarity.

Please drop a short text, we will publish it at the docs page.

[DrDBanner]

Something like this:

IMPORTANT NOTE FOR ANY COMPOSER OR CLI INSTALLATION

Due to historical reasons we must ask you kindly to rename the themes folders of the theme and child theme. Otherwise the child theme is not able to find the main theme. This not needed if you download the zip versions.

after a git clone or composer require

cd wp-content/themes/
mv bootscore bootscore-main
mv bootscore-child bootscore-child-main

This is a temporary solution until we are able to rename our repositories.

[crftwrk]

Thanks, nearly.

IMPORTANT NOTE FOR ANY COMPOSER OR CLI INSTALLATION

We're trying to avoid important and capital letters. We can use an alert or heading for this. Instructions should be part of https://bootscore.me/documentation/installation/#Composer.

Due to historical reasons we must ask you kindly to rename the themes folders of the theme and child theme.

We'll never kindly ask someone to do something using our work, we give instructions and provide help.

Otherwise the child theme is not able to find the main theme

This affects not only the child, it affects all themes and plugins.

This is a temporary solution until we are able to rename our repositories.

Wrong. This will affect <1% of the users and branch name is included in folders since years without any issues. What I said with v6 means that we can discuss this and check if it's worth to go this step or not in v6.

[DrDBanner]

So you ask me to write a short text. I deliver, and you reply with a lecture without need. You'll manage to write an appropriate text, I think. Have a great week.