-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex doesn't compile under clang-cl with warnings-as-errors=on #219
Comments
Or maybe the file should just define |
#220 implements the first suggested fix. I'll make a second PR for the second. |
#221 implements the second suggested fix. I've verified locally that both work. |
jzmaddock
added a commit
that referenced
this issue
Sep 3, 2024
Define _CRT_SECURE_NO_WARNINGS instead of using wcscpy_s. Fixes #219.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
E.g. https://github.com/boostorg/unordered/actions/runs/10655219740/job/29532497175?pr=277#step:6:489
This wasn't a problem before the modular changes because Serialization is referenced with
<warnings>off
herehttps://github.com/boostorg/unordered/blob/21937249c47da1fbdb445dc40775a88832fd772d/test/Jamfile.v2#L156
However, post the modular changes Serialization depends on Regex, and
<warnings>off
doesn't get propagated to the Regex build for some reason, resulting in the error above.I see that a PR addressing this (#218) has already been merged, but it doesn't seem to help for some reason.
The preprocessor condition should probably check for the MS STL, rather than specific compilers.
The text was updated successfully, but these errors were encountered: