Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/Jamfile overrides <warnings> #223

Closed
pdimov opened this issue Sep 2, 2024 · 1 comment
Closed

build/Jamfile overrides <warnings> #223

pdimov opened this issue Sep 2, 2024 · 1 comment

Comments

@pdimov
Copy link
Member

pdimov commented Sep 2, 2024

As mentioned in #219, linking to /boost/serialization//boost_serialization/<warnings>off doesn't propagate <warnings>off to Regex, which breaks when warnings-as-errors is on.

That's because build/Jamfile contains

project : requirements
   # default to all warnings on:
   <warnings>all
   : common-requirements <library>$(boost_dependencies)
   : requirements <library>$(boost_dependencies_private)
   ;

which overrides the inherited <warnings>off with <warnings>all.

The comment says "default to all warnings on", but since it's a requirement, it's not a default and is always applied.

It should be put in default-build instead.

@pdimov
Copy link
Member Author

pdimov commented Sep 2, 2024

(or removed altogether - <warnings>all should be used when testing, not when building.)

jzmaddock added a commit that referenced this issue Sep 3, 2024
Move <warnings>all from requirements to default-build. Fixes #223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant