Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused warning in fields_count.hpp #187

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

anarthal
Copy link
Contributor

@anarthal anarthal commented Oct 9, 2024

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11258716667

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11253776824: 0.0%
Covered Lines: 407
Relevant Lines: 407

💛 - Coveralls

@anarthal
Copy link
Contributor Author

anarthal commented Oct 9, 2024

Would you be open to a PR that changes CIs to use warnings-as-errors=on and warnings=extra so Boost.PFR is ensured to be clean of common warnings for downstream consumers (like me)?

@apolukhin
Copy link
Member

warnings-as-errors=on and warnings=extra

Would you be open to a PR that changes CIs to use warnings-as-errors=on and warnings=extra so Boost.PFR is ensured to be clean of common warnings for downstream consumers (like me)?

Sounds good, please make a PR

@apolukhin apolukhin merged commit 69263f4 into boostorg:develop Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants