-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prelim fix issue586 (if none better found) #587
Conversation
It's green-ish with CodeCov upload error (re-running) and 1 timeout on drone. Hi @jzmaddock do you think the potential fix in this PR is sufficient? Cc: @mborland |
I'll take a look shortly. |
That's fine, a simpler fix is:
which doesn't then require a temporary. |
Thank you John. It is now cycling in CI. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #587 +/- ##
==========================================
- Coverage 94.1% 84.6% -9.5%
==========================================
Files 273 149 -124
Lines 28523 16332 -12191
==========================================
- Hits 26833 13805 -13028
- Misses 1690 2527 +837
... and 159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hi Matt (@mborland) in Multiprecision, uploading Coverage from suite number 1 takes too long and times out all the time, or a lot of the time. We need to eventually look into this. I can help when we both have a time slot for this... Cc: @jzmaddock |
In math every test suite gets its own coverage run because just doing suite 1 and suite 2 also had issues with timeouts. Porting that logic is likely the easiest way to solve this. |
I appreciate that. Many thanks @mborland |
The purpose of this PR is to provide a minimalistic fix to #586.
In that issue, we see a phenomenon that may require conversion to number-wrap or non-wrapped type detected in overloads of
trunc
andlltrunc
.If no better fix is found in this releasce cycle, then this does the trick.
Cc: @jzmaddock John take a look if you find better...
Cc: @mborland Standalone with/without the presence of
Math
.Cc: @radj307