-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made BOOST_CHARCONV_HAS_QUADMATH a usage requirement in the Jamfile #252
Made BOOST_CHARCONV_HAS_QUADMATH a usage requirement in the Jamfile #252
Conversation
|
Thanks for the run down. Your part looks good; I'll come behind and clean up newly exposed warnings/errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
========================================
Coverage 94.85% 94.85%
========================================
Files 69 69
Lines 9085 9085
========================================
Hits 8618 8618
Misses 467 467
Continue to review full report in Codecov by Sentry.
|
Removed unnecessary BOOST_CHARCONV_NO_QUADMATH macro definition from CMake
Changed all BOOST_CHARCONV_HAS_FLOAT128 usages into BOOST_CHARCONV_HAS_QUADMATH, which is guaranteed to be correctly propagated
Fixed tests that had missing includes, unnoticed due to being ifdef-ed out by BOOST_CHARCONV_HAS_QUADMATH
close #249