Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superflous assignment to exponent argument in parser #240

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Flamefire
Copy link
Contributor

The exponent will be parsed later, the value assigned at this position is meaningless or even wrong.

The exponent will be parsed later, the value assigned at this position
is meaningless or even wrong.
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (8fbdb8a) to head (9e4975c).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
- Coverage    94.76%   94.76%   -0.01%     
===========================================
  Files           69       69              
  Lines         9031     9030       -1     
===========================================
- Hits          8558     8557       -1     
  Misses         473      473              
Files with missing lines Coverage Δ
include/boost/charconv/detail/parser.hpp 79.68% <ø> (-0.11%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbdb8a...9e4975c. Read the comment docs.

@mborland mborland merged commit 41caca1 into boostorg:develop Jan 2, 2025
70 checks passed
@Flamefire Flamefire deleted the superflous-exp branch January 2, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants