-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 카카오 로그인 로직 구현 #98
Conversation
iOS/Layover/Layover/Network/EndPoint/Factories/LoginEndPointsFactory.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로직상 문제되거나 하는 부분은 없는 것 같아 궁금한 부분 위주로 남겨놓았습니다!
수고하셨어요 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 버튼 터치 interactive false줘도 안됐나요? 암튼 고생하셨습니당당~
bodyParameters.updateValue(socialToken, forKey: "accessToken") | ||
|
||
return EndPoint( | ||
path: "/oauth/kakao", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘네 다 static으로 관리하는건 별론가요?? 각종 상수 String들
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 static으로 선언하면 외부에 값을 노출시키게 되는데 다른 이점이 있나요?
재사용을 하지 말아야 할 값이라 생각되어서 우선 저렇게 선언했었습니다...!
아하...시도해보지는 못했는데, 버튼에 직접 설정하면 버튼 위에 설정되는 컴포넌트들의 Constraint 설정 코드를 없앨 수 있어서 바꾸었습니다 ㅠㅠ |
🧑🚀 PR 요약
📌 변경 사항
Note
로그인 화면 UI를 변경했습니다.
Note
LoginEndPointFactory 를 선언했습니다.
Note
카카오 로그인 로직을 구현했습니다.
📸 ScreenShot
Linked Issue
close #85