feat: 재생화면 뷰에 재생 뷰 넣기 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
탭바 위에 뜰 수 있도록 수정
기존에 상위 뷰에 있어서 라벨 아니는 부분도 터치됐는데 이 부분을 라벨만 되도록 수정
메소드 분리, 더미 데이터 내용 변경
애니메이션시 라벨 내용이 다 안보이던 버그 수정
loinsir
reviewed
Nov 24, 2023
Comment on lines
+11
to
+13
| lazy var tagButton1: UIButton = setButton("#밤샘") | ||
| lazy var tagButton2: UIButton = setButton("#시차") | ||
| lazy var tagButton3: UIButton = setButton("#고양이") |
There was a problem hiding this comment.
setButton함수 들어가야 해서 그랬을 거에요 VIP싸이클 적용하게 되면 바뀔 것 같습니다
anyukyung
reviewed
Nov 24, 2023
| guard let windowHeight = (windowScene?.screen.bounds.height) else { | ||
| return | ||
| } | ||
| playerSlider.frame = CGRect(x: 0, y: (windowHeight - tabbar.frame.height - LOSlider.loSliderHeight), width: playerSliderWidth, height: LOSlider.loSliderHeight) |
There was a problem hiding this comment.
컨벤션에 맞게 인자마다 들여쓰기하면 보기좋을 것 같습니다!
anyukyung
reviewed
Nov 24, 2023
Comment on lines
+136
to
+137
| playerView.player?.isMuted = true | ||
| playerView.play() |
There was a problem hiding this comment.
isMuted 시뮬에서 돌리면 시끄러워서 놔둔거라 신경 안쓰셔도 될 것 같습니다.
anyukyung
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
📌 변경 사항
여러 버그들을 수정하면서 세세한 수정사항이 있습니다. 확인해주시면 감사하겠습니다.
📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2023-11-24.at.00.48.47.mp4
Linked Issue
close #59