feat: 유저 프로필 화면 구성 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopmozzi
approved these changes
Nov 22, 2023
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| setNavigationBar() |
There was a problem hiding this comment.
navibar는 viewWillAppear시점에 하는게 낫지 않나요?
There was a problem hiding this comment.
지금 상황에서 viewDidLoad에서 호출해줬을때 안좋은 점이나 문제될 만한게 떠오르지 않는데
어떤 점에서 더 좋을지 알려주실 수 있을까요 !
loinsir
reviewed
Nov 22, 2023
Comment on lines
+19
to
+22
| enum ProfileType { | ||
| case own | ||
| case other | ||
| } |
loinsir
reviewed
Nov 22, 2023
| clipsToBounds = true | ||
| } | ||
|
|
||
| private func setConstraints() { |
There was a problem hiding this comment.
view 백그라운드 색상을 바꿔버렸더니, 구분이 안돼서 깜빡하고 호출을 안했네여 수정하겠습니다 !!!
loinsir
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
해당 pr에서 작업한 내역을 적어주세요.
📌 변경 사항
변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.
📸 ScreenShot
작동, 구현화면
Linked Issue
close #55