-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 지도 탭 캐러셀 반복재생 및 LoopingPlayerView
, createCarouselLayout
변경 사항
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyukyung
force-pushed
the
iOS/feat#46
branch
from
November 21, 2023 06:21
ea6bded
to
da488d2
Compare
loinsir
reviewed
Nov 21, 2023
chopmozzi
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다. 디테일한 부분들 수정하시면 좋을 것 같아요
iOS/Layover/Layover/Scenes/MapScene/MapCarouselCollectionViewCell.swift
Outdated
Show resolved
Hide resolved
iOS/Layover/Layover/Scenes/MapScene/MapCarouselCollectionViewCell.swift
Outdated
Show resolved
Hide resolved
loinsir
reviewed
Nov 21, 2023
loinsir
reviewed
Nov 21, 2023
iOS/Layover/Layover/Scenes/MapScene/MapCarouselCollectionViewCell.swift
Outdated
Show resolved
Hide resolved
셀 내부 center, side 함수 제거 URL 관련 프로퍼티 네이밍 변경 강제언래핑 삭제
chopmozzi
approved these changes
Nov 21, 2023
loinsir
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 반영 확인했습니다. 고생하셨습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
해당 pr에서 작업한 내역을 적어주세요.
지금은 맥시멈 크기의 90%가 되는 순간 셀을 재생하게 됩니다.
📌 변경 사항
변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.
LoopingPlayerView에 isPlaying 프로퍼티 추가했습니다
공통으로 사용하는 부분이라 미리 말씀드렸어야하는데... 시간이 너무 늦어 우선 추가해보았습니다..
불필요하다거나 더 좋은 방법이 있다 싶으시면 말씀해주세용
player의 timeControlStatus 여부로 판단하도록 했습니다.
그리고 isPlaying 여부를 판단해서 play, pause하도록 수정했습니다..
createCarouselLayout를 makeCarouselSection으로..
visibleItemsInvalidationHandler를 다시 사용해야했습니다.
📸 ScreenShot
작동, 구현화면
Linked Issue
close #46