Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 지도 셀 커스텀 리소스 적용 및 black screen flash 현상 제거 #343

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

anyukyung
Copy link
Member

🧑‍🚀 PR 요약

해당 pr에서 작업한 내역을 적어주세요.

  • 지도 셀 커스텀 리소스를 적용했습니다.
  • 영상 재생 초반에 black screen이 깜빡이던 현상을 제거했습니다.

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

📸 ScreenShot

작동, 구현화면

RPReplay_Final1704894208.MP4

Linked Issue

close #333

Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가된 커스텀 로더를 사용하신건가요? 고생하셨습니다.

at: .centeredHorizontally,
animated: false)
guard let cell = carouselCollectionView.cellForItem(at: indexPath) as? MapCarouselCollectionViewCell else { return }
cell.play()
Copy link
Collaborator

@loinsir loinsir Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재생 시점이 이곳으로 이동했군요. 스크롤 가운데 재생은 더이상 되지 않는건가요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가운데 스크롤시 selectAnntation이 호출되면서 재생되도록 했습니다!!

Copy link
Collaborator

@loinsir loinsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@anyukyung anyukyung merged commit 94a6c1e into iOS/dev Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants