test: Playback Interactor, Presenter 테스트 코드 작성 #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
reviewed
Dec 12, 2023
뷰는 테스트 안해주셔도 됩니다! |
loinsir
reviewed
Dec 12, 2023
iOS/Layover/LayoverTests/Mocks/Workers/MockPlaybackWorekr.swift
Outdated
Show resolved
Hide resolved
loinsir
reviewed
Dec 13, 2023
iOS/Layover/LayoverTests/Scenes/Playback/PlaybackInteractorTests.swift
Outdated
Show resolved
Hide resolved
anyukyung
reviewed
Dec 13, 2023
| if post.board.videoURL == nil { | ||
| continue | ||
| } | ||
| tempVideos.append(post) |
There was a problem hiding this comment.
if let 써서 videoURL있을 때만 append하는게 더 직관적일 것 같은 느낌?
anyukyung
approved these changes
Dec 13, 2023
|
@anyukyung 아뇨 지금 최대한 고쳐볼게용.... |
loinsir
reviewed
Dec 13, 2023
|
|
||
| // MARK: - Tests | ||
|
|
||
| func test_displayVideoList를_호출하면_presentVideoList를_호출하고_올바른_데이터를_전달한다_parentView가_map일_때() async { |
There was a problem hiding this comment.
자연스럽게 읽힐 수 있도록 ~~일 때 라는 말이 어순으로 들어오면 좋을 것 같습니다
loinsir
reviewed
Dec 13, 2023
| // videos는 Hashable | ||
| XCTAssertEqual(spy.displayVideoListViewModel.videos.first!, Seeds.PlaybackVideos.videos.first!) | ||
| XCTAssertEqual(spy.displayVideoListViewModel.videos.last!, Seeds.PlaybackVideos.videos.last!) | ||
| XCTAssertEqual(spy.displayVideoListViewModel.videos.count, 2) |
There was a problem hiding this comment.
count 체크가 선행되어서, 실패 시 뒤 로직을 실행하지 못하게 하면 테스트 시간을 단축할 수 있을 것 같습니다.
loinsir
reviewed
Dec 13, 2023
| let response: Models.SeekVideo.Response = Models.SeekVideo.Response(willMoveLocation: willMoveLocation, currentCell: previousCell) | ||
| presenter?.presentSeekVideo(with: response) | ||
| } | ||
|
|
||
| func hidePlayerSlider() { | ||
| guard let previousCell else { return } | ||
| previousCell.playbackView.playerSlider?.isHidden = true |
There was a problem hiding this comment.
이건 interactor에서 뷰를 조작하는 동작일까요...?
loinsir
approved these changes
Dec 13, 2023
|
@loinsir @anyukyung 저 이 브랜치 Pr 닫고 브랜치 새로 파서 진행할게요. 어디서부터 꼬였는지 감도 안잡혀요 지금 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
�Playback Interacotr와 Presenter의 테스트 코드를 작성했습니다.
ViewController는 아직 못했습니다. 정신 나갈것 같아요.
구조이슈........로 테스트 안되는 케이스들이 두갠가 있습니다.
이 친구들은 버그 고치고, 정신 좀 말짱할 때 할 게요.
📸 ScreenShot
Linked Issue
close #311