feat: 프로필 변경 화면 VIP 구현 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyukyung
reviewed
Dec 9, 2023
anyukyung
reviewed
Dec 9, 2023
anyukyung
reviewed
Dec 9, 2023
anyukyung
reviewed
Dec 9, 2023
iOS/Layover/Layover/Scenes/EditProfile/EditProfileViewController.swift
Outdated
Show resolved
Hide resolved
chopmozzi
approved these changes
Dec 9, 2023
iOS/Layover/Layover/Scenes/EditProfile/EditProfileViewController.swift
Outdated
Show resolved
Hide resolved
Closed
1 task
anyukyung
reviewed
Dec 9, 2023
chopmozzi
approved these changes
Dec 9, 2023
anyukyung
reviewed
Dec 9, 2023
anyukyung
reviewed
Dec 9, 2023
anyukyung
reviewed
Dec 9, 2023
|
|
||
| override func setUI() { | ||
| super.setUI() | ||
| self.title = "프로필 수정" | ||
| title = "프로필 수정" | ||
| interactor?.fetchProfile(with: Models.FetchProfile.Request()) |
There was a problem hiding this comment.
이거는 왜 setUI에서 호출하시�는 걸까요? 따로 네트워킹 없이 데이터 소스로 정보만 받아오는거라 그런가요?
There was a problem hiding this comment.
네 따로 사이드 이펙트 없이 가져온다고 생각했고, setUI도 viewDidLoad가 실행시켜주는 메서드라 생각해서 이곳에서 호출했습니다.
호옥시 다른 좋은 의견이 있으실까요?
There was a problem hiding this comment.
오옹 아뇨 지금도 괜찮은 것 같습니다 취향차이인 것 같아요 !
There was a problem hiding this comment.
음 뭔가 이름이... fetch라고 되어있어서 가져오는 의미가 강해서 그런 느낌이 들 수 있겠네요.
네트워킹으로 요청하는 것도 아닌데, setProfile이라고 하면 좀 더 명확할 것 같습니다. 수정할게요
anyukyung
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
📌 변경 사항
Note
PHPickerController로 프로필 이미지 데이터 접근 처리
loadFileRepresentation메서드는 인자로 넘겨주는 url이 해당 클로저 내에서만 유효한 임시적인 파일 url입니다.그 외, 프로필 변경 이후 프로필 화면으로 다시 복귀할 때 변경한 데이터로 적용시켜주기 위해,
viewWillAppear로 프로필 데이터를 가져오는 시점을 변경했습니다.
📸 ScreenShot
Linked Issue
close #236