상품 정보 조회 promise 방식 변경 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sickbirdd
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
진행 내용
주기적 상품 정보 조회 시, 하나의 상품 조회 promise가 실패할 경우 모든 promise가 실패되는 현상 개선
기존에는 Promise.all로 인해 하나의 promise만 reject되더라도 모든 promise가 실패되었는데, 해당 현상을 개선하기 위해
Promise.allSettled를 이용하여 성공한 promise와 실패한 promise를 따로 처리할 수 있도록 변경하였습니다.