Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundSlider 커스텀 뷰 추가 #240

Merged
merged 51 commits into from
Jan 27, 2024
Merged

RoundSlider 커스텀 뷰 추가 #240

merged 51 commits into from
Jan 27, 2024

Conversation

ootr47
Copy link
Collaborator

@ootr47 ootr47 commented Jan 5, 2024

진행 내용

  • 슬라이더 ui 구현
  • 슬라이드 체인지 리스너 추가
  • 슬라이더 속성 변경 함수 제공 (highlightRange, value, maxPercentValue
  • 슬라이더 색상 지정
  • SetTargetPriceFragment에 슬라이더 적용
  • -, + 버튼 추가하기

스크린샷

  1. width : wrap_content, height : wrap_content
KakaoTalk_Video_2024-01-08-20-50-50.mp4
  1. width : 0dp, height : wrap_content
KakaoTalk_Video_2024-01-08-20-50-46.mp4
  1. width : 0dp, height : wrap_content
binding.roundSlider.setMaxPercentValue(180)
binding.roundSlider.setValue(10)
binding.roundSlider.setHighlightRange(100, 120)
KakaoTalk_Video_2024-01-08-20-50-53.mp4

최종

KakaoTalk_Video_2024-01-15-19-21-16.mp4

@ootr47 ootr47 added feature 새로운 기능 android 안드로이드 관련 labels Jan 5, 2024
@ootr47 ootr47 self-assigned this Jan 5, 2024
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 8, 2024
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 8, 2024
@ootr47 ootr47 marked this pull request as ready for review January 8, 2024 12:07
@ootr47 ootr47 marked this pull request as ready for review January 22, 2024 08:38
@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 22, 2024
Copy link
Collaborator

@EunhoKang EunhoKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항이 정말 많네요. 고생 많으셨습니다.
아, 그리고 이건 그냥 질문인데 SliderValueChangeListener.kt에서
typealias를 쓰셨던데 function type을 그대로 쓰는 것에 비해 어떤 장점이 있나요?

@ootr47
Copy link
Collaborator Author

ootr47 commented Jan 25, 2024

아, 그리고 이건 그냥 질문인데 SliderValueChangeListener.kt에서
typealias를 쓰셨던데 function type을 그대로 쓰는 것에 비해 어떤 장점이 있나요?

typealias는 샘플 코드 참고한 것인데 단순히 타입 그대로 지정했을 때 보다 typealias로 이름을 지정한 것이 코드를 이해하기 쉽다고 느껴져서 사용해봤습니다.

@boostcampwm2023 boostcampwm2023 deleted a comment from github-actions bot Jan 25, 2024
Copy link
Member

@Taewan-P Taewan-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Member

@Taewan-P Taewan-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Collaborator

@EunhoKang EunhoKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!

@EunhoKang EunhoKang merged commit cc2d4f4 into dev/and Jan 27, 2024
2 checks passed
@Taewan-P Taewan-P deleted the feat/and/custom-slider branch May 21, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 안드로이드 관련 feature 새로운 기능
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants