닉네임 UI #98
Merged
닉네임 UI #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2taezeat
reviewed
Nov 16, 2023
android/feature/login/src/main/java/com/ohdodok/catchytape/feature/login/NicknameFragment.kt
Show resolved
Hide resolved
|
꼼꼼하게 하셨네요, 고생하셨습니다~ |
2taezeat
approved these changes
Nov 16, 2023
HamBP
reviewed
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
기존 google login button 에 정의된 스타일들을 추출하여 공통 button style 로 정의하였다. 기본 button color 는 키 컬러이고, google login button 만 grey 컬러로 변경해서 지정해줌
Text selection can be customized using your palette accent color.참고text 선택 도구 컬러를 accent color 를 사용하고 있어서 app 의 accent color 를 정의해주었다.
text highlight color 로 정의
Screenshot (optional)