Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keystore 공유를 위한 설정 #92

Merged
merged 3 commits into from
Nov 15, 2023
Merged

keystore 공유를 위한 설정 #92

merged 3 commits into from
Nov 15, 2023

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Nov 15, 2023

Issue

Overview

  • 디버그 사이닝 키스토어를 공유할 수 있다.
  • GitHub Actions settings에 debug.keystore 및 keystore.properties 추가
  • workflow에서 해당 변수를 가져오도록 설정
  • 빌드시 build.gradle에 명시된 keystore를 통해 사이닝

@HamBP HamBP added 🚀 CI / CD CI / CD ⚙️ setting 환경 세팅 🤖 android android labels Nov 15, 2023
@HamBP HamBP added this to the 🔧 etc milestone Nov 15, 2023
@HamBP HamBP self-assigned this Nov 15, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4f6d601.

♻️ This comment has been updated with latest results.

@HamBP HamBP linked an issue Nov 15, 2023 that may be closed by this pull request
Key Store 맞추기 #89
Closed
2taezeat
2taezeat approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

youlalala
youlalala approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

@HamBP HamBP merged commit 1778c8b into develop Nov 15, 2023
2 checks passed
@HamBP HamBP deleted the android/feature/cd branch November 16, 2023 07:10
youlalala
youlalala reviewed Nov 18, 2023
View reviewed changes
.github/workflows/android-pull-request-ci.yml
DEBUG_KEYSTORE: ${{ secrets.DEBUG_KEYSTORE }}
KEYSTORE_PROPERTIES: ${{ secrets.KEYSTORE_PROPERTIES }}
run: |
echo "$DEBUG_KEYSTORE" | base64 -d > keystore.properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 오타 발견했어욥 !! keystore.properties 가 아니라 debug.keystore 로 바꿔야할 것 같습니당

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엥 그러네요 왜 발견은 못 했지...?

@HamBP HamBP modified the milestones: 🔧 etc, 🦾 CI/CD Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youlalala youlalala youlalala approved these changes

@2taezeat 2taezeat 2taezeat approved these changes

Assignees

@HamBP HamBP

Labels
🤖 android android 🚀 CI / CD CI / CD ⚙️ setting 환경 세팅
Projects
None yet
Milestone
🦾 CI/CD
Development

Successfully merging this pull request may close these issues.

Key Store 맞추기
3 participants
@HamBP @2taezeat @youlalala