로그인 화면 구성 #91
Merged
로그인 화면 구성 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
HamBP
reviewed
Nov 15, 2023
Comment on lines
13
to
18
| <dimen name="login_icon_size">201dp</dimen> | ||
| <dimen name="login_icon_margin_vertical">168dp</dimen> | ||
|
|
||
| <dimen name="login_width">300dp</dimen> | ||
| <dimen name="login_height">50dp</dimen> | ||
| <dimen name="login_radius">10dp</dimen> |
There was a problem hiding this comment.
로그인 아이콘이 아마 우리 앱 아이콘인 거 같은데, login보다는 앱 아이콘과 관련된 이름으로 짓는 게 좋을 거 같아! 201 말고 200으로 해도 될 듯?
width는 parent 기준으로 사이징해서 없어도 될 거 같구
height는 로그인 버튼이 아니라 그냥 버튼 사이즈라 버튼 관련된 이름으로 바꾸면 좋을 듯!
There was a problem hiding this comment.
login radius 도 btn radius로 바꾸면 좋을듯!
HamBP
reviewed
Nov 15, 2023
Comment on lines
2
to
3
| android:width="18dp" | ||
| android:height="18dp" |
There was a problem hiding this comment.
이거 래핑 안 된 아이콘으로 받은 거 같은데 래핑된 아이콘으로 받아야 할 거 같아. 나중에 정렬에 문제가 생겨서
HamBP
reviewed
Nov 15, 2023
Comment on lines
3
to
7
| import androidx.lifecycle.ViewModel | ||
|
|
||
| class LoginViewModel : ViewModel() { | ||
|
|
||
|
|
There was a problem hiding this comment.
HiltViewModel 어노테이션은 나중에 할때 해도 될듯!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ScreenShot