Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service 계층에서 발생하는 에러 상태 코드 수정 #417

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

sk000801
Copy link
Member

@sk000801 sk000801 commented Feb 22, 2024

Issue

Overview

  • BAD_REQUEST -> SERVER_ERROR로 수정
    (서버 네트워크 등의 문제로 발생한 에러가 잘못된 요청 상태 코드로 표시되고 있었음)
  • DELETE /users user 모듈로 옮김

별건 아니라서 한번 보시고 어푸룹 해주심 될 것 같아용!

* 서버 네트워크 환경 등의 이유로 발생한 에러를 BAD_REQUEST로 잘못 명시하여 수정
* 서버 네트워크 환경 등의 이유로 발생한 에러를 BAD_REQUEST로 잘못 명시하여 수정
@sk000801 sk000801 added this to the 📝 login milestone Feb 22, 2024
@sk000801 sk000801 self-assigned this Feb 22, 2024
@sk000801 sk000801 linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@khw3754 khw3754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

* 사용자를 삭제하는 API는 용도가 user 모듈가 더 가까워 옮김
@sk000801 sk000801 merged commit d7180df into develop Feb 23, 2024
1 check passed
@sk000801 sk000801 deleted the server/refactor/416 branch February 23, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

기존 Auth 모듈 HTTP 상태 코드 수정
2 participants