검색 화면 UX 개선, more 버튼시 출력 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamBP
reviewed
Dec 12, 2023
| @@ -60,16 +59,19 @@ class SearchViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| private fun observeKeyword() { | |||
| _keyword.filter { it.isNotBlank() } | |||
There was a problem hiding this comment.
notBlank 필터링 하는 건 괜찮았던 거 같은데, 지운 이유가 있을까?
There was a problem hiding this comment.
filter가 있으면 fetchSearchedMusics가 호출�이 안되서 옮겼습니다~
HamBP
reviewed
Dec 12, 2023
Comment on lines
+31
to
+38
| fun playMusic(music: Music) { | ||
| val newPlaylist = CurrentPlaylist( | ||
| startMusic = music, | ||
| musics = listOf(music), | ||
| ) | ||
|
|
||
| scope.launch { _currentPlaylist.send(newPlaylist) } | ||
| } |
There was a problem hiding this comment.
이 부분은 최근 재생한 목록을 추가해 주면 더 좋을 듯?
근데 그냥 머지해도 됩니당
youlalala
approved these changes
Dec 12, 2023
| @@ -19,6 +19,9 @@ | |||
| android:layout_width="0dp" | |||
| android:layout_height="44dp" | |||
| android:layout_margin="@dimen/margin_horizontal" | |||
| android:inputType="text" | |||
| android:maxLines="1" | |||
| android:imeOptions="actionDone" | |||
There was a problem hiding this comment.
actionDone 넣어 준 것 좋네요! action Search 를 넣어도 좋을 것 같아여 (나중에 해도됨)
There was a problem hiding this comment.
actionSearch보다 actionDone이 UX가 더 좋아서, 일부러 actionDone 넣었습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview