Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle 더 간소화 #331

Merged
merged 2 commits into from
Dec 12, 2023
Merged

gradle 더 간소화 #331

merged 2 commits into from
Dec 12, 2023

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Dec 12, 2023

Issue

Overview

  • defaultConfig 및 난독화 코드 추출

To Reviewers

  • 여전히 gradle이 길긴해서 모듈 추가할 때 무엇을 추가하고 무엇을 삭제할 지 헷갈렸는데, 간소화 했어

@HamBP HamBP added this to the 🔧 etc milestone Dec 12, 2023
@HamBP HamBP self-assigned this Dec 12, 2023
@HamBP HamBP linked an issue Dec 12, 2023 that may be closed by this pull request
gradle 더 간소화 #330
Closed
youlalala
youlalala approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네용 ㅎㅎ

@github-actions GitHub Actions
Copy link

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 951335f.

2taezeat
2taezeat approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@HamBP HamBP merged commit 7a90c14 into develop Dec 12, 2023
2 checks passed
@HamBP HamBP deleted the androie/feature/330 branch December 12, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youlalala youlalala youlalala approved these changes

@2taezeat 2taezeat 2taezeat approved these changes

Assignees

@HamBP HamBP

Labels
🤖 android android 🧦 chore Chore
Projects
None yet
Milestone
🔧 etc
Development

Successfully merging this pull request may close these issues.

gradle 더 간소화
3 participants
@HamBP @2taezeat @youlalala