Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

음악을 재생목록에 추가할 때 발생하는 이슈 처리 #328

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Dec 12, 2023

Issue

Overview

  • Fragment를 띄우면 하단 재생 바가 자기 부른 줄 알고 같이 올라옴 (해결)
  • 예외 처리(이미 추가된 노래일 경우 등)가 안 되어 있음 (해결)
  • 정상적으로 추가되면 알림 메시지를 띄워줘야 함 (해결)
  • 이유는 모르겠으나 바텀 시트가 떠 있는 동안 재생 버튼이 사라짐 (미결)
  • UI radius 추가하거나 디자인을 바꿔야 함 (미결)
  • 사진 썸네일이 짤리는 현상 (미결)

To Reviewers

중요한 이슈 먼저 해결했어

@HamBP HamBP added 🐞 bug 버그 수정 🤖 android android labels Dec 12, 2023
@HamBP HamBP added this to the ⏯️ playlist milestone Dec 12, 2023
@HamBP HamBP self-assigned this Dec 12, 2023
Copy link

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0

Results for commit a3656ad.

Comment on lines +61 to +64
private fun showMessage(@StringRes messageId: Int) {
Toast.makeText(requireActivity(), messageId, Toast.LENGTH_SHORT).show()
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base fragment 에 showMessage 사용하지 않은 이유가 있을까용?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseFragment를 상속 받지 않았어요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아항 제가 잘못봤네용

Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@HamBP HamBP merged commit d1ec8cf into develop Dec 12, 2023
2 checks passed
@HamBP HamBP deleted the android/feature/298 branch December 12, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android 🐞 bug 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants