Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

재생 목록 추가시 UI 즉시 반영 #327

Merged
merged 1 commit into from
Dec 12, 2023
Merged

재생 목록 추가시 UI 즉시 반영 #327

merged 1 commit into from
Dec 12, 2023

Conversation

HamBP
Copy link
Member

@HamBP HamBP commented Dec 12, 2023

Issue

Overview

  • 클래스 이름과 파일 이름이 불일치하여 리팩토링 PlaylistViewModel -> PlaylistsViewModel
  • 재생 목록 추가 후 다시 fetch

@HamBP HamBP added 🐞 bug 버그 수정 🤖 android android labels Dec 12, 2023
@HamBP HamBP added this to the ⏯️ playlist milestone Dec 12, 2023
@HamBP HamBP self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link

Test Results

6 tests   6 ✔️  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 0ed536c.

@HamBP HamBP linked an issue Dec 12, 2023 that may be closed by this pull request
재생목록 추가시 UI에 즉시 표시 #326
Closed
youlalala
youlalala approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@youlalala youlalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

2taezeat
2taezeat approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@2taezeat 2taezeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@HamBP HamBP merged commit b2471e7 into develop Dec 12, 2023
2 checks passed
@HamBP HamBP deleted the feature/android/326 branch December 12, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youlalala youlalala youlalala approved these changes

@2taezeat 2taezeat 2taezeat approved these changes

Assignees

@HamBP HamBP

Labels
🤖 android android 🐞 bug 버그 수정
Projects
None yet
Milestone
⏯️ playlist
Development

Successfully merging this pull request may close these issues.

재생목록 추가시 UI에 즉시 표시
3 participants
@HamBP @2taezeat @youlalala