이전, 다음 곡 이동 불가능 상태 UI #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
youlalala
approved these changes
Dec 7, 2023
HamBP
reviewed
Dec 7, 2023
| </vector> | ||
|
|
||
| </item> | ||
| <item android:state_enabled="false"> |
HamBP
reviewed
Dec 7, 2023
Comment on lines
+50
to
+54
| var nextEnabled: Boolean = false | ||
| set(value) { | ||
| field = value | ||
| binding.ibNext.isEnabled = value | ||
| } |
There was a problem hiding this comment.
(단순 코멘트) 값을 유지할필요가 없다면 fun NextEnabled()와 같이 배킹 필드가 없는 세터 함수 형태로 작성하면 더 짧은 코드로 작성할 수 있을 듯
HamBP
reviewed
Dec 7, 2023
| it.copy( | ||
| duration = duration, | ||
| currentMusic = playlist.musics[index], | ||
| isNextEnable = playlist.musics.size != index + 1, |
There was a problem hiding this comment.
(단순 코멘트) 리스트에는 lastIndex 라는 확장 프로퍼티도 있어
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
공통 로직은 최대한PlayerUtil.kt에 작성 하였습니다!PlayerUtil.kt코드가 줄었습니다Screenshot